Skip to content

test(tail): fix flaky test_follow_name_multiple on macOS #9636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
naoNao89 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test(tail): fix flaky test_follow_name_multiple on macOS #9636

naoNao89 wants to merge 2 commits into from

Conversation

@naoNao89
Copy link
Contributor

@naoNao89 naoNao89 commented Dec 11, 2025 •
edited
Loading

Fixes CI: #9587 #9632

Fixes flaky test_follow_name_multiple by increasing timeout from 500ms to 3000ms on macOS.

Root cause: macOS FS caching delays output visibility when test framework reads redirected temp files.

for i in {1..5}; do echo "=== Run $i ==="; cargo test --test tests test_tail::test_follow_name_multiple -- --nocapture 2>&1 |grep -A 2 "test test_tail::test_follow_name_multiple"; done
=== Run 1 ===
test test_tail::test_follow_name_multiple ... FAILED

failures:

failures:
    test_tail::test_follow_name_multiple
=== Run 2 ===
test test_tail::test_follow_name_multiple ... FAILED

failures:

failures:
    test_tail::test_follow_name_multiple
=== Run 3 ===
test test_tail::test_follow_name_multiple ... FAILED

failures:

failures:
    test_tail::test_follow_name_multiple
=== Run 4 ===
test test_tail::test_follow_name_multiple ... FAILED

failures:

failures:
    test_tail::test_follow_name_multiple
=== Run 5 ===
test test_tail::test_follow_name_multiple ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 3691 filtered out; finished in 7.61s

https://github.com/uutils/coreutils/actions/runs/20132879326/job/57778876765
https://github.com/uutils/coreutils/actions/runs/20113818498/job/57718649405?pr=9629

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 11, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9636 will degrade performances by 3.24%

Comparing naoNao89:fix/tail-follow-name-multiple-files (e02607d) with main (415d01c)1

Summary

⚡ 1 improvement
❌ 3 regressions
✅ 123 untouched
⏩ 6 skipped2

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ sort_numeric 23.2 ms 24 ms -3.24%
⚡ mv_multiple_to_dir 13.1 ms 12.9 ms +2.05%
❌ unexpand_large_file[10] 549.3 ms 562.8 ms -2.4%
❌ unexpand_many_lines[100000] 262 ms 268.4 ms -2.4%

Footnotes

  1. No successful run was found on main (4a1b969) during the generation of this report, so 415d01c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@naoNao89
test(tail): fix flaky test_follow_name_multiple on macOS
e02607d 
Increase timeout from 500ms to 1300ms on macOS to account for file system
caching delays when reading redirected output from temp files.
@naoNao89 naoNao89 force-pushed the fix/tail-follow-name-multiple-files branch from b365cab to e02607d Compare December 11, 2025 22:32
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@naoNao89 naoNao89 mentioned this pull request Dec 18, 2025
Merged
@ChrisDryden ChrisDryden mentioned this pull request Dec 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@naoNao89 @sylvestre